Skip to content

fix(findings): stabilize evidence signatures#97

Merged
steipete merged 2 commits into
openclaw:mainfrom
rohitjavvadi:fix/stable-finding-evidence-signatures
May 22, 2026
Merged

fix(findings): stabilize evidence signatures#97
steipete merged 2 commits into
openclaw:mainfrom
rohitjavvadi:fix/stable-finding-evidence-signatures

Conversation

@rohitjavvadi
Copy link
Copy Markdown
Contributor

@rohitjavvadi rohitjavvadi commented May 20, 2026

Summary

This makes fallback finding signatures deterministic when two provider results describe the same evidence with different object key order or evidence array order. The signature still changes when the evidence content changes.

Fixes #83.

Verification

  • Added focused regression coverage for stable evidence signatures
  • Ran the focused findings test
  • Ran the full test suite
  • Ran typecheck, lint, format check, diff check, and build

@steipete steipete merged commit 1229c60 into openclaw:main May 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

findingFromOutput signature is not stable across re-reviews: JSON.stringify(evidence) is key-order-dependent

2 participants